Repository details — GitHub-aligned Issues / PR tab icons (Octicons)#1178
Conversation
|
Hi, @anderdc Unexpectedly I updated many versions of package-lock.json file while installing new module. |
|
fix conflicts |
|
Fixed conflicts, please review again. |
anderdc
left a comment
There was a problem hiding this comment.
Please scope this down to what #1179 asks for. Keep: the RepositoryDetailsPage tab-icon swap, the single new dependency. Drop: the unrelated package-lock.json version bumps — regenerate the lockfile so it reflects only the one added module.
|
I just removed updated versions as you required. Please review again. |
|
This is a cosmetic swap of two tab icons that pulls in a new dependency for github.com parity — not worth the dependency or the lockfile churn. Closing. |
Summary
The repository details page tabs for Issues and Pull Requests used Material UI icons that did not match github.com:
BugReportIconfor Issues andMergeTypeIconfor PRs. That created an inconsistent meaning for anyone toggling between GitHub and Gittensor.Related Issues
Closes #1179
Type of Change
Screenshots
Before
Untitled273.mp4
After
after.mp4
Checklist
npm run formatandnpm run lint:fixhave been runnpm run buildpassesSolution
IssueOpenedIconandGitPullRequestIconfrom@primer/octicons-react.BugReportIconand the Pull Requests tabMergeTypeIconinRepositoryDetailsPage.tsx.Boxcomponent="span"withdisplay: 'inline-flex',alignItems: 'center',mr: 1, andcolor: 'inherit'so size (16) and spacing stay consistent with other tabs and the SVG picks up the tab’s text color.Files
src/pages/RepositoryDetailsPage.tsxpackage.json@primer/octicons-react(if not already present in the branch)