fix: prevent BackButton from navigating outside the app#1196
Closed
zp6 wants to merge 1 commit into
Closed
Conversation
Fixes entrius#1162 The shared BackButton used on every detail page now checks document.referrer to determine whether the previous history entry belongs to this app. When the referrer is missing or points to a different origin (fresh tab, shared link, bookmark), the button falls back to the configured in-app route instead of calling navigate(-1) which would leave the app. This mirrors the fix already applied to the 404 page's own back button and extends it to every detail page that uses the shared BackButton component.
Collaborator
|
Duplicate of #1160 which is better scoped/implemented. Closing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1162
The shared BackButton used on every detail page now checks document.referrer to determine whether the previous history entry belongs to this app. When the referrer is missing or points to a different origin (fresh tab, shared link, bookmark), the button falls back to the configured in-app route instead of calling
avigate(-1) which would leave the app.
Changes:
Testing: