fix(dashboard): Fixes a dashboard crash when rendering the **Total Lines Committed** KPI.#1224
Open
bcExpt1123 wants to merge 2 commits into
Open
fix(dashboard): Fixes a dashboard crash when rendering the **Total Lines Committed** KPI.#1224bcExpt1123 wants to merge 2 commits into
bcExpt1123 wants to merge 2 commits into
Conversation
The lines total endpoint returns { linesCommitted }, not a bare number.
Passing the object into KpiCard caused a React render crash on the dashboard.
Collaborator
|
Fix conflicts. |
Contributor
Author
|
@anderdc |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a dashboard crash when rendering the Total Lines Committed KPI.
GET /dash/lines/totalreturns{ linesCommitted: number }, but the client typed and consumed it as a barenumber. The full response object was passed intobuildDashboardKpisand thenKpiCard, which triggered:Objects are not valid as a React child (found: object with keys {linesCommitted})Changes:
LinesTotaltype matching the API responseuseLinesTotalwithLinesTotalinstead ofnumberlinesTotalQuery.data?.linesCommitted ?? 0inuseDashboardDatabefore building KPIsRelated Issues
fixes #1223
Type of Change
Screenshots
Before:
After:
Checklist
npm run formatandnpm run lint:fixhave been runnpm run buildpasses