refactor(watchlist): extract shared useWatchlistMinerStats hook#1245
Open
Khaostica wants to merge 1 commit into
Open
refactor(watchlist): extract shared useWatchlistMinerStats hook#1245Khaostica wants to merge 1 commit into
Khaostica wants to merge 1 commit into
Conversation
Watchlist `WatchlistPage` and `MinersList` each ran the same `useAllMiners` → `mapAllMinersToStats(...)` → filter watched githubIds → map(isEligible: OSS || Discoveries) pipeline in a local useMemo. Hoist into a single `useWatchlistMinerStats(minerIds)` hook so the sidebar `Miners Activity` widgets and the table/cards row data share one source. No behavior change — just removes a near-duplicate useMemo block from each call site. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
83e7b83 to
01a707b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
WatchlistPageandMinersListeach ran the sameuseAllMiners()→mapAllMinersToStats(...)→ filter watchedgithubIds →map(isEligible: OSS || Discoveries)pipeline in a localuseMemo. Hoist that into a singleuseWatchlistMinerStats(minerIds)hook so the page-level sidebarMiners Activitywidgets and the table/cards row data share one source.No behavior change —
MinersListalready passed throughisLoadingand the rawallMinersDatafor its "unresolved miners" warning, both of which the new hook returns alongside the mappedminersarray.Related Issues
Type of Change
Screenshots
Not applicable — no rendered output changes. The watchlist Miners tab renders the same numbers from the same data source as before, just from a shared hook.
Checklist
npm run formatandnpm run lint:fixhave been runnpm run buildpasses