fix(repositories): weight precision, paginated next-page, drop repo-name tooltip#1249
Merged
Conversation
… reset, drop repo-name tooltip - formatWeight helper rounds weights to up to 5 decimals and trims trailing zeros, replacing the toFixed(2) calls that were turning small shares like 0.0035 into "0.04" across the repositories table, leaderboard cards, repository details, search results, and watchlist views. - setFilter in useDataTableParams now only clears the page slot when the filter value actually changes. react-router rebuilds setSearchParams on every URL update, which propagated through useCallback deps and caused DebouncedSearchInput's effect to re-emit '', wiping the page param immediately after next-page was clicked (most visible at rows=12). - Remove the hover tooltip on the repository-name cell in the repositories table.
entrius
approved these changes
May 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
formatWeighthelper formats weight/share values up to 5 decimals and trims trailing zeros (so0.00350renders as0.0035, not0.04). Applied across the repositories table, leaderboard card, search results, watchlist row + bar chart, and the repository-details Stats panel. Tooltips and axis labels that surfacedWeightuse it too.useDataTableParams.setFilterso it only clears thepageslot when the filter value actually changes. react-router-dom rebuildssetSearchParamson every URL change; that propagated throughuseCallbackdeps and re-firedDebouncedSearchInput's effect, which calledsetFilter('search', '')and wiped thepageparam immediately afternext-pagewas clicked. Most visible in cards view withrows=12, but also caused deep links like?page=Nto reset on load.Test plan
?page=1and rows "13–15 of 15" render (verified via Playwright against local dev server)./repositories?page=1keeps you on page 1.page(filter value actually changed).npx tsc -bandeslintclean.