fix(miners): show dates in PR table date column#1252
Open
victortran0904 wants to merge 2 commits into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
Fixes the miner detail Pull Requests table so the Date column displays an actual date for all PR states (open/closed/merged), aligning the cell renderer with the column’s intent.
Changes:
- Add
getPrDateLabelhelper to choose the appropriate displayed date (merged →mergedAt, closed →closedAt/prCreatedAt, open →prCreatedAt). - Update the Date column’s
renderCellto use the new helper.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+114
to
+117
| const getPrDateLabel = (pr: CommitLog): string => { | ||
| if (pr.mergedAt) return formatDate(pr.mergedAt); | ||
| if (pr.prState === 'CLOSED') return formatDate(pr.closedAt || pr.prCreatedAt); | ||
| return formatDate(pr.prCreatedAt); |
Author
|
Updated to address the Copilot comment: the Date column sort now uses the same effective date as the renderer ( Verification:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1111.
Verification
Note: the local pre-commit hook failed only because lint-staged/prettier split this workspace path at spaces (
New project 2). The same lint and build checks passed manually.