refactor(format): add pluralize helper and replace inline plural ternaries#1270
Open
Dexterity104 wants to merge 1 commit into
Open
refactor(format): add pluralize helper and replace inline plural ternaries#1270Dexterity104 wants to merge 1 commit into
Dexterity104 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a
pluralizehelper tosrc/utils/format.tsand replaces inline${n} thing${n !== 1 ? 's' : ''}ternaries at the sites most prone to plural typos. The helper handles regular plurals ('commit'→'commits') and takes an explicit second form for irregular ones (pluralize(n, 'bounty', 'bounties')).No behavior change. Rendered output is byte identical at every call site, including the
0 thingsand1 thingedge cases.Call sites updated:
src/components/ContributionHeatmap.tsxsrc/components/miners/MinerPrScoreDetail.tsxsrc/pages/dashboard/views/FeaturedWorkRepoCard.tsxsrc/pages/RepositoriesPage.tsxsrc/pages/RepositoryDetailsPage.tsxsrc/pages/search/SearchPage.tsxsrc/utils/repoConfig.tsSites where the count and noun appear in separate positions (split by an adjective or rendered as a fraction) were left alone to avoid restructuring the surrounding markup.
Related Issues
N/A
Type of Change
Screenshots
Not applicable. Pure logic refactor with no visual change.
Checklist
npm run formatandnpm run lint:fixhave been runnpm run buildpasses