fix: updates image generation request tracing to match latest OpenInference #1520
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:L
Contributor
Author
|
will work on this more when online again (long flight ahead) |
codefromthecrypt
force-pushed
the
fix/image-generation-tracing
branch
from
277ac56 to
9dd7bf0
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1520 +/- ##
=======================================
Coverage 83.93% 83.93%
=======================================
Files 144 144
Lines 12667 12670 +3
=======================================
+ Hits 10632 10635 +3
Misses 1419 1419
Partials 616 616 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
- Span name changed to ImagesResponse - Add output.mime_type and output.value attributes - Add llm.invocation_parameters attribute - Remove llm.model_name from request attributes - Fix missing RecordResponse call in translator - Refactor tests to match chat/embeddings style Signed-off-by: Adrian Cole <[email protected]>
codefromthecrypt
force-pushed
the
fix/image-generation-tracing
branch
from
9dd7bf0 to
8fff806
Compare
Contributor
Author
|
note I also polished test style, since codecov is angry anyway |
nacx
approved these changes
Nov 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
updates image generation request tracing to match latest OpenInference
Related Issues/PRs (if applicable)
#1519