ci: Optimize shebang of bash scripts to enhance compatibility (#33431)

Replace `#!/bin/bash` with `#!/usr/bin/env bash` in bash scripts to ensure they execute with the bash specified by the local environment(#33426)

Signed-off-by: xocodergit <[email protected]>

bazel/coverage/fuzz_coverage_wrapper.sh

@@ -1,4 +1,6 @@
-#!/bin/bash -e
+#!/usr/bin/env bash
+
+set -e
 
 TEST_BINARY=$1
 shift

bazel/external/boringssl_fips.genrule_cmd

@@ -1,4 +1,4 @@
-#!/bin/bash
+#!/usr/bin/env bash
 
 set -e
 

bazel/gen_sh_test_runner.sh

@@ -1,4 +1,4 @@
-#!/bin/bash
+#!/usr/bin/env bash
 
 # Used in a genrule to wrap sh_test script for execution in
 # //test/coverage:coverage_tests single binary.

bazel/get_workspace_status

@@ -1,4 +1,4 @@
-#!/bin/bash
+#!/usr/bin/env bash
 
 # This file was imported from https://github.com/bazelbuild/bazel at d6fec93.
 

bazel/setup_clang.sh

@@ -1,4 +1,6 @@
-#!/bin/bash -e
+#!/usr/bin/env bash
+
+set -e
 
 BAZELRC_FILE="${BAZELRC_FILE:-./clang.bazelrc}"
 

bazel/setup_local_tsan.sh

@@ -1,4 +1,4 @@
-#!/bin/bash
+#!/usr/bin/env bash
 
 BAZELRC_FILE="${BAZELRC_FILE:-$(bazel info workspace)/local_tsan.bazelrc}"
 

bazel/sh_test_wrapper.sh

@@ -1,4 +1,4 @@
-#!/bin/bash
+#!/usr/bin/env bash
 
 # Dummy shell implementation for nooping tests.
 # TODO(lizan): remove when we have a solution for

bazel/test/verify_tap_test.sh

@@ -1,4 +1,4 @@
-#!/bin/bash
+#!/usr/bin/env bash
 
 set -ex
 

bazel/test_for_benchmark_wrapper.sh

@@ -1,4 +1,4 @@
-#!/bin/bash
+#!/usr/bin/env bash
 
 # Set the benchmark time to 0 to just verify that the benchmark runs to
 # completion.  We're interacting with two different flag parsers, so the order

bazel/version_update_post.sh

@@ -1,5 +1,6 @@
-#!/bin/bash -e
+#!/usr/bin/env bash
 
+set -e
 set -o pipefail
 
 

bazel/volatile_env.sh

@@ -1,4 +1,6 @@
-#!/bin/bash -e
+#!/usr/bin/env bash
+
+set -e
 
 if [[ ! -f bazel-out/volatile-status.txt ]]; then
     # shellcheck disable=SC2016

ci/build_setup.sh

@@ -1,4 +1,4 @@
-#!/bin/bash
+#!/usr/bin/env bash
 
 # Configure environment variables for Bazel build and test.
 

ci/check_and_fix_format.sh

@@ -1,4 +1,4 @@
-#!/bin/bash
+#!/usr/bin/env bash
 
 set -e
 

ci/do_ci.sh

@@ -1,4 +1,4 @@
-#!/bin/bash
+#!/usr/bin/env bash
 
 # Run a CI build/test target, e.g. docs, asan.
 

ci/docker_ci.sh

@@ -1,4 +1,4 @@
-#!/bin/bash
+#!/usr/bin/env bash
 
 # Do not ever set -x here, it is a security hazard as it will place the credentials below in the
 # CI logs.

ci/docker_rebuild_google-vrp.sh

@@ -1,4 +1,4 @@
-#!/bin/bash
+#!/usr/bin/env bash
 
 # Script to rebuild Dockerfile-envoy-google-vrp locally (i.e. not in CI) for development purposes.
 # This makes use of the latest envoy:dev base image on Docker Hub as the base and takes an

ci/envoy_build_sha.sh

@@ -1,4 +1,4 @@
-#!/bin/bash
+#!/usr/bin/env bash
 
 
 ENVOY_BUILD_CONTAINER="$(grep envoyproxy/envoy-build-ubuntu "$(dirname "$0")"/../.bazelrc | sed -e 's#.*envoyproxy/envoy-build-ubuntu:\(.*\)#\1#' | uniq)"

ci/filter_example_setup.sh

@@ -1,4 +1,4 @@
-#!/bin/bash
+#!/usr/bin/env bash
 
 # Configure environment for Envoy Filter Example build and test.
 

ci/format_pre.sh

@@ -1,4 +1,6 @@
-#!/bin/bash -E
+#!/usr/bin/env bash
+
+set -E
 
 # Pre-checks for validation and linting
 #

ci/mac_ci_setup.sh

@@ -1,4 +1,4 @@
-#!/bin/bash
+#!/usr/bin/env bash
 
 # Installs the dependencies required for a macOS build via homebrew.
 # Tools are not upgraded to new versions.

ci/mac_ci_steps.sh

@@ -1,4 +1,4 @@
-#!/bin/bash
+#!/usr/bin/env bash
 
 set -e
 

ci/reopen_branch.sh

@@ -1,4 +1,6 @@
-#!/bin/bash -e
+#!/usr/bin/env bash
+
+set -e
 
 ENVOY_GIT_USERNAME="${ENVOY_GIT_USERNAME:-envoy-bot}"
 ENVOY_GIT_EMAIL="${ENVOY_GIT_EMAIL:-envoy-bot@users.noreply.github.com}"

ci/run_clang_tidy.sh

@@ -1,4 +1,4 @@
-#!/bin/bash
+#!/usr/bin/env bash
 
 set -eo pipefail
 

ci/run_envoy_docker.sh

@@ -1,4 +1,4 @@
-#!/bin/bash
+#!/usr/bin/env bash
 
 set -e
 

ci/test_docker_ci.sh

@@ -1,4 +1,4 @@
-#!/bin/bash
+#!/usr/bin/env bash
 
 # Run this with `./ci/test_docker_ci.sh`.
 #

ci/upload_gcs_artifact.sh

@@ -1,4 +1,4 @@
-#!/bin/bash
+#!/usr/bin/env bash
 
 set -e -o pipefail
 

ci/verify_examples.sh

@@ -1,4 +1,6 @@
-#!/bin/bash -E
+#!/usr/bin/env bash
+
+set -E
 
 TESTFILTER="${1:-*}"
 TESTEXCLUDES="${2}"

configs/configgen.sh

@@ -1,4 +1,4 @@
-#!/bin/bash
+#!/usr/bin/env bash
 
 set -e
 

configs/google-vrp/launch_envoy.sh

@@ -1,4 +1,4 @@
-#!/bin/bash
+#!/usr/bin/env bash
 
 cd /etc/envoy || exit
 envoy "$@"

contrib/cryptomb/private_key_providers/test/test_data/generate-keys.sh

@@ -1,4 +1,4 @@
-#!/bin/bash
+#!/usr/bin/env bash
 
 set -e
 

contrib/qat/private_key_providers/test/test_data/generate-keys.sh

@@ -1,4 +1,4 @@
-#!/bin/bash
+#!/usr/bin/env bash
 
 set -e
 

distribution/distrotest.sh

@@ -1,4 +1,6 @@
-#!/bin/bash -E
+#!/usr/bin/env bash
+
+set -E
 
 FAILED=()
 TESTNAME=

mobile/bazelw

@@ -1,4 +1,4 @@
-#!/bin/bash
+#!/usr/bin/env bash
 
 set -euo pipefail
 

mobile/ci/linux_ci_setup.sh

@@ -1,4 +1,4 @@
-#!/bin/bash
+#!/usr/bin/env bash
 
 set -e
 

mobile/ci/mac_ci_setup.sh

@@ -1,4 +1,4 @@
-#!/bin/bash
+#!/usr/bin/env bash
 
 set -e
 

mobile/ci/start_android_emulator.sh

@@ -1,4 +1,4 @@
-#!/bin/bash
+#!/usr/bin/env bash
 
 set -e
 

mobile/ci/start_ios_simulator.sh

@@ -1,4 +1,4 @@
-#!/bin/bash
+#!/usr/bin/env bash
 
 set -euo pipefail
 

mobile/ci/test_size_regression.sh

@@ -1,5 +1,6 @@
-#!/bin/bash -e
+#!/usr/bin/env bash
 
+set -e
 set -o pipefail
 
 # Checks the absolute size and the relative size increase of a file.

mobile/docs/build.sh

@@ -1,4 +1,4 @@
-#!/bin/bash
+#!/usr/bin/env bash
 
 set -e
 

mobile/docs/publish.sh

@@ -1,4 +1,6 @@
-#!/bin/bash -e
+#!/usr/bin/env bash
+
+set -e
 
 # This is run on every commit that GitHub Actions picks up. It assumes that docs have already been
 # built via docs/build.sh. The commit behavior differs depending on the nature of the commit:

mobile/remote

@@ -1,4 +1,4 @@
-#!/bin/bash
+#!/usr/bin/env bash
 
 set -euo pipefail
 

mobile/third_party/rbe_configs/cc/cc_wrapper.sh

@@ -1,4 +1,4 @@
-#!/bin/bash
+#!/usr/bin/env bash
 #
 # Copyright 2015 The Bazel Authors. All rights reserved.
 #

mobile/tools/ktfmt.sh

@@ -1,4 +1,4 @@
-#!/bin/bash
+#!/usr/bin/env bash
 
 set -euo pipefail
 

source/common/version/generate_version_linkstamp.sh

@@ -1,4 +1,4 @@
-#!/bin/bash
+#!/usr/bin/env bash
 
 # This script generates a header file that is used by version_lib whenever linkstamp is not allowed.
 # linkstamp is used to link in version_linkstamp.cc into the version_lib.

test/common/runtime/filesystem_setup.sh

@@ -1,4 +1,4 @@
-#!/bin/bash
+#!/usr/bin/env bash
 
 set -e
 

test/common/tls/ocsp/test_data/certs.sh

@@ -1,4 +1,4 @@
-#!/bin/bash
+#!/usr/bin/env bash
 #
 # Create test certificates and OCSP responses for them for unittests.
 

test/common/tls/test_data/certs.sh

@@ -1,4 +1,4 @@
-#!/bin/bash
+#!/usr/bin/env bash
 
 set -e
 

test/config/integration/certs/certs.sh

@@ -1,4 +1,4 @@
-#!/bin/bash
+#!/usr/bin/env bash
 
 set -e
 

test/config_test/example_configs_test_setup.sh

@@ -1,4 +1,4 @@
-#!/bin/bash
+#!/usr/bin/env bash
 
 set -e
 

test/exe/build_id_test.sh

@@ -1,4 +1,4 @@
-#!/bin/bash
+#!/usr/bin/env bash
 
 set -e -o pipefail
 

test/exe/envoy_static_test.sh

@@ -1,4 +1,4 @@
-#!/bin/bash
+#!/usr/bin/env bash
 
 ENVOY_BIN=${TEST_SRCDIR}/envoy/source/exe/envoy-static
 

test/exe/pie_test.sh

@@ -1,4 +1,4 @@
-#!/bin/bash
+#!/usr/bin/env bash
 
 set -e
 

test/exe/version_out_test.sh

@@ -1,4 +1,4 @@
-#!/bin/bash
+#!/usr/bin/env bash
 
 set -e -o pipefail
 

test/extensions/filters/network/thrift_proxy/driver/generate_bindings.sh

@@ -1,4 +1,4 @@
-#!/bin/bash
+#!/usr/bin/env bash
 
 # Generates the thrift bindings for example.thrift. Requires that
 # apache-thrift's thrift generator is installed and on the path.

test/extensions/filters/network/thrift_proxy/driver/generate_fixture.sh

@@ -1,4 +1,4 @@
-#!/bin/bash
+#!/usr/bin/env bash
 
 # Generates request and response fixtures for integration tests.
 

test/fuzz/fuzz_runner_launcher.sh

@@ -1,4 +1,4 @@
-#!/bin/bash
+#!/usr/bin/env bash
 #
 # Launcher for the fuzz runner engine.
 # See https://github.com/bazelbuild/rules_fuzzing for more info.

test/integration/admin_html/test_server_test.sh

@@ -1,4 +1,4 @@
-#!/bin/bash
+#!/usr/bin/env bash
 
 tmp="${TEST_TMPDIR}/test/integration/admin_html/tempfiles"
 export ENVOY_BIN="${TEST_SRCDIR}/envoy/test/integration/admin_html/test_server"

test/integration/admin_html/web_test.sh

@@ -1,4 +1,4 @@
-#!/bin/bash
+#!/usr/bin/env bash
 #
 # This test is semi-automatic. It builds envoy-static with
 # ENVOY_ADMIN_BROWSER_TEST set, then runs the binary in a mode where

test/integration/hotrestart_test.sh

@@ -1,4 +1,4 @@
-#!/bin/bash
+#!/usr/bin/env bash
 
 # In order to get core dumps that can be debugged, uncomment the following line and then run
 # the test using --spawn_strategy=local. (There may be a better way of doing this but this worked

test/integration/run_envoy_test.sh

@@ -1,4 +1,4 @@
-#!/bin/bash
+#!/usr/bin/env bash
 
 export ENVOY_BIN="${TEST_SRCDIR}/envoy/test/integration/hotrestart_small_main"
 

test/integration/sds_dynamic_key_rotation_setup.sh

@@ -1,4 +1,4 @@
-#!/bin/bash
+#!/usr/bin/env bash
 
 set -e
 

test/integration/test_utility.sh

@@ -1,4 +1,4 @@
-#!/bin/bash
+#!/usr/bin/env bash
 
 # Helper script for bash integration tests, intended to be source'd from the
 # _test.sh.

test/per_file_coverage.sh

@@ -1,4 +1,4 @@
-#!/bin/bash
+#!/usr/bin/env bash
 
 # directory:coverage_percent
 # for existing directories with low coverage.