ext_proc: Fix filter protocol configuration encoding with per-route config #39650
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e overrides Signed-off-by: Yanjun Xiang <[email protected]>
yanjunxiang-google
changed the title
Signed-off-by: Yanjun Xiang <[email protected]>
|
/assign @tyxia |
yanjunxiang-google
requested review from
tyxia,
mattklein123 and
yanavlasov
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If processing mode exists in per-router configuration, it overrides what's in the HTTP filter configuration.
The final processing mode configurations are stored in the filter decoding_state_ and encoding_state_. Encoding them when sending those modes to the ext_proc server.
This PR is a followup of #38755, which missed the per-route override part.