-
Notifications
You must be signed in to change notification settings - Fork 5.2k
adding socket options apis in dynamic modules #42784
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Thanks for the contribution, @VivekSubr! You'll have to also update the ABI Version SHA and expose the RUST bindings for this change :) /wait |
Signed-off-by: VivekSubr <[email protected]>
Signed-off-by: VivekSubr <[email protected]>
Signed-off-by: VivekSubr <[email protected]>
Signed-off-by: VivekSubr <[email protected]>
|
@VivekSubr Looks like it's missing coverage: /wait |
Signed-off-by: VivekSubr <[email protected]>
Signed-off-by: VivekSubr <[email protected]>
Signed-off-by: VivekSubr <[email protected]>
|
Got all the PR checks to pass, attaching test pcap screenshot for reference, This pcap was taken using this test code: https://github.com/VivekSubr/Client-Server/tree/main/proxy/envoy/dynamic_modules/dscp_filter This filter, added via dynamic modules, sets http response header using 'x-dscp' header from request. I think this is good to merge... @agrawroh |
agrawroh
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with some minor nits. Thanks!
|
CC @envoyproxy/api-shepherds: Your approval is needed for changes made to |
Signed-off-by: VivekSubr <[email protected]>
Signed-off-by: Vivek Subramanian <[email protected]>
Signed-off-by: VivekSubr <[email protected]>
|
cc @wbpcode Could you please take another look as Sr. Extension Maintainer? |

Commit Message:
Additional Description: Adding apis to setsockopt and getsockopt to dynamic modules abi... this is a use case un-supported by wasm filters.
Risk Level: Low, new apis
Testing: Tested manually, verified using pcap, test code is available here: https://github.com/VivekSubr/Client-Server/tree/main/proxy/envoy/dynamic_modules/dscp_filter
Docs Changes: NA? I think dynamic modules apis aren't documented function by function.
Release Notes: Added envoy_dynamic_module_callback_http_set_socket_option and envoy_dynamic_module_callback_http_get_socket_option to dynamic modules abi.