-
Notifications
You must be signed in to change notification settings - Fork 5.2k
dynamic_modules: add more methods to network filters ABI #42815
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f10140d to
54d57f9
Compare
b84da13 to
3012ada
Compare
d0ae9b3 to
0eac11f
Compare
Signed-off-by: Rohit Agrawal <[email protected]>
0eac11f to
71ea41f
Compare
wbpcode
reviewed
Jan 5, 2026
Member
wbpcode
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, i forgot to submit my comments. And could you ensure all the ABI has the correct comments:)
Signed-off-by: Rohit Agrawal <[email protected]>
781a681 to
7d10e54
Compare
wbpcode
approved these changes
Jan 6, 2026
Member
wbpcode
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks.
botengyao
pushed a commit
to botengyao/envoy
that referenced
this pull request
Jan 6, 2026
…42815) Signed-off-by: Boteng Yao <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds support for more methods in Dynamic Modules for Network Filters to make HTTP callouts.
Commit Message: dynamic_modules: add more methods to network filters ABI
Additional Description: Adds support for more methods in Dynamic Modules for Network Filters to make HTTP callouts.
Risk Level: Low
Testing: Added Tests
Docs Changes: Added
Release Notes: N/A