filter chain refactoring: add more context for FilterChainFactoryCallbacks #42844
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wbpcode
requested review from
kyessenov,
mattklein123,
tyxia and
yanavlasov
as code owners
Member
Author
|
I initially thought this could help to address the problem in the #42807. But as @yanavlasov said, it is not general solution. We need more discussion about 42807. After a thought, I think this is still helpful for filters who want to control the filter creation based on known context anyway (although cannot control the filter creation based on the previous filters' processing). So I still kept this PR. |
Signed-off-by: wbpcode/wangbaiping <[email protected]>
wbpcode
force-pushed
the
dev-add-method-to-filter-chain-callback
branch
from
89bb424 to
9d6d3a5
Compare
Signed-off-by: wbpcode/wangbaiping <[email protected]>
Member
Author
|
/retest |
Signed-off-by: wbpcode/wangbaiping <[email protected]>
Member
Author
|
/retest |
1 similar comment
Member
Author
|
/retest |
yanavlasov
approved these changes
Jan 6, 2026
botengyao
pushed a commit
to botengyao/envoy
that referenced
this pull request
Jan 6, 2026
…backs (envoyproxy#42844) This PRs contains: 1. expose request headers, stream info and so on at the `FilterChainFactoryCallbacks`, the the filter factory could get more context about current stream to create a filter. 2. allow the filter factory to set the filterConfigName() which is helpful for the case where a single filter factory want to inject multiple different filters to chain. Risk Level: mid. core code change. Testing: n/a. Docs Changes: n/a. Release Notes: n/a. Platform Specific Features: n/a. --------- Signed-off-by: wbpcode/wangbaiping <[email protected]> Signed-off-by: Boteng Yao <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit Message: filter chain refactoring: add more context for FilterChainFactoryCallbacks
Additional Description:
This PRs contains:
FilterChainFactoryCallbacks, the the filter factory could get more context about current stream to create a filter.Risk Level: mid. core code change.
Testing: n/a.
Docs Changes: n/a.
Release Notes: n/a.
Platform Specific Features: n/a.