Repository navigation
Conversation
claxn
commented
Aug 5, 2026
claxn
commented
Collaborator
- changed "conversions" to "Conversions" attribute
- removed standard_name length restriction
- updated tests, README and docstrings
ignaciomasari
approved these changes
Aug 6, 2026
ignaciomasari
left a comment
ignaciomasari
left a comment
Contributor
There was a problem hiding this comment.
as we are changing the name of a variable, I guess this would be a breaking change. wouldn't that merit a major version change to 0.3.0? Everything else looks perfect
Collaborator
Author
|
@ignaciomasari thanks for the comments and good point about the version! I would even say we move it to 1.0.0, since we will update the package name anyway (I will create a separate PR)? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.