Repository navigation
refactor: share stream history delivery across transports - #295
Merged
Merged
Conversation
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing. Review the Copilot code review billing settings.
This was referenced Oct 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Historical replay currently depends directly on Socket.IO framing and acknowledgements. Extract a small delivery interface so the additive native stream adapter can reuse the existing Elasticsearch queries, filters, metadata shaping, readiness/proof checks and scroll cleanup.
streamPastCommonremains the legacy wrapper; its adapter preserves the existing packet shape and per-batch acknowledgement behavior.Every delivery connection must provide disconnect listeners. A focused regression confirms an in-flight canonical proof is cancelled and its listener removed.
HistoryStart.firstBlockis explicitly the first matching hit; the native adapter must resolve its actual inclusive replay anchor separately.This is the first bounded slice of #294. The native endpoint, count/byte flow control, history/live coordination and pinned cross-language conformance remain subsequent work; #294 and #231 stay open. No dependency, configuration, default activation or retained-history change.
Validation at
e21a54cf913e54f3cc53cf417ebfba110e81794c:7e7f018bae39a255b787e3b3b884e31ffeca9bf3; its tree matches the reviewed head. All nine post-merge CI jobs passed.The separate real uWebSockets/Socket.IO listener probe supports
/streamand/stream/v2coexistence, but is not endpoint or public protocol qualification.