Skip to content

fix: recover reversible inputs under replacement sources - #326

Merged
igorls merged 3 commits into
feat/source-bound-attempt-adjudicationfrom
codex/reversible-recovery
Oct 25, 2026
Merged

igorls merged 3 commits into
feat/source-bound-attempt-adjudicationfrom
codex/reversible-recovery

Conversation

@igorls

@igorls igorls commented Oct 25, 2026 •

Copy link
Copy Markdown
Member

A reader replacement could skip unpublished reversible inputs because its resume point came from ABI coverage. Replaying the original block could then collide with a history plan that omitted its retained source context.

Preserve the confirmed publication cursor and anchor, fence obsolete callbacks, and bind new history plans to their exact retained input. Schema-1 identities and complete provenance/conflict checks remain intact. The original native worker case replays the requested prefix and recovers block 33 with its own fresh result and end while the revoked attempt stays held, then completes block 34 and redelivery.

Validation at 418137f4: complete-project typecheck and native emission pass; native Node 24/26 controls and saved-evidence regressions pass. The local full suite reports 1,489 pass / 18 platform or optional skips / 0 fail. All nine CI jobs pass; both Linux Node 24/26 unit legs report 1,506 pass / 1 optional skip / 0 fail. Independent complete-delta Spec/Standards reviews have no remaining scoped findings, and recorded-evidence custody inspection is complete. Copilot could not review because quota was unavailable.

Builtin Antelope's reversible selected-source bridge remains open in #321; parent #289 stays draft. Combined live recovery, full original replay/capacity and release qualification remain separate. No public activation or production deployment.

Fixes #324
Fixes #325
Refs #321, #288 and #277.

Separate confirmed publication progress from ABI coverage and bind new action history plans to retained source context. Preserve legacy identities, full provenance fingerprints and original source/end validators.

Fixes #324

Fixes #325

Refs #321

igorls commented Oct 25, 2026

Copy link
Copy Markdown
Member Author

Standards

Independent review of the complete a808b317...fbee53aa delta (15 files) found no actionable documented-standard violations or Fowler smells. Publication ownership, explicit schema compatibility, immutable fingerprints and the engineering activation boundary are preserved. This static review makes no runtime or release acceptance claim.

Spec

One P2 saved-evidence consistency finding: the checker authenticates retained association ends against native replies, but separately reported end copies are not joined to those complete records. Root reproduced the new recovery-copy case: changing only its reported payload hash still passed, with stored records, original IPC and native ends unchanged. The correction will compare positive report ends with their associations and old/late-RPC ends with their original native replies, with contradictory-copy regressions.

The scoped publication/source-plan fixes otherwise match #324/#325. Builtin Antelope's reversible selected-source bridge remains a separate open #321 requirement. No additional production defect or scope creep found.

Totals at fbee53aa: Standards 0 findings; Spec 1 P2 consistency finding, correction pending. This commit is not final acceptance. Its ongoing frozen suite and completed native controls retain their original source identity; the corrected commit will receive fresh validation and complete-delta re-reviews.

Compare all positive report ends with their typed associations and old ends with exact native replies. Reject contradictory report copies without changing stored evidence or original IPC. Retain the reproduced review counterexample.
Replay the requested canonical suffix before fresh irreversible confirmation. Preserve the original constructed observation fault during replay and keep publication progress independent of ABI coverage.

igorls commented Oct 25, 2026

Copy link
Copy Markdown
Member Author

Standards

Independent final review of all three commits and 17 files in a808b317...418137f4 found zero documented-standard breaches or actionable Fowler smells. Publication ownership, explicit legacy/scoped plan compatibility, complete fingerprints, immutable conflicts and the activation boundary remain intact. The replay fixture preserves its original constructed observation fault and confirmed-publication gate.

Spec

The prior P2 is resolved. Positive report ends now equal their complete typed associations, which equal the exact native replies; old and late-RPC report ends also require complete native equality. Native regression controls change each applicable report copy while preserving stores, original IPC/ends and inputs, then require rejection. The original contradiction and failed host expectations remain retained at their original source identities.

The scoped #324/#325 requirements have no remaining actionable defect or scope creep. Builtin Antelope's reversible selected-source bridge remains explicitly open under #321. Static review does not replace final execution or establish live-chain, capacity or release acceptance.

Totals at 418137f4: Standards 0 findings; Spec 0 scoped findings. The one issue-wide Antelope gate remains open. Final native Node 24/26 controls and cold regressions pass; the full suite and CI are still running.

@igorls
igorls marked this pull request as ready for review October 25, 2026 18:49
Copilot AI balanced review requested due to automatic review settings October 25, 2026 18:49

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.

An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing. Review the Copilot code review billing settings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants