Repository navigation
test: sample Mongo recovery within the original phase deadline - #343
Conversation
|
Independent review of the complete ten-file delta at StandardsZero documented-standard violations. One nonblocking P3 judgement: the sampler repeats the auditor's canonical comparator; a small shared qualification helper could prevent divergence. This remains a recorded cleanup suggestion. SpecZero findings across all ten files. The original isolation deadline covers fresh logical/API/physical samples; only a complete sample-bound admission transition retries. Independent invariant, timeout and capture failures remain fatal. Earlier rejected samples are retained. Both reviewers independently passed all 51 controls on native Node 24.19.0 and 26.4.0, including the preserved intentional failure. Root hash-verified the reports/evidence, literal patch replay, fixture identities and its own 51-case runs, typechecks/build and physical-audit tests. All nine exact-head CI jobs passed. Both Linux build legs report 1,586 passed / 1 optional skip / zero failures / 10,609 assertions across 1,587 tests and 143 files; both also execute the 51 new native controls. The focused Hyperion-3 actual-auditor check remains pending: an initial post-run wrapper failed before retaining the original child exit, so that attempt is not accepted despite its passing helper report and verified cleanup. Fresh cases preserve the failed wrapper evidence. Source/component review does not establish historical causality, full Wire replay or release acceptance. Summary: Standards 0 rule violations, 1 nonblocking P3; Spec 0 findings. |
f4df8c4
into
feat/source-bound-attempt-adjudication
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing. Review the Copilot code review billing settings.
|
Post-merge verification: |
A fresh admission can change the same pending projection's diagnostic reason after an earlier detached logical recovery view was read. The old worker qualifier could then reject the physical snapshot despite preserved source/binding state. A controlled replay reproduces that mechanism; the historical service interleaving remains unknown.
Sample fresh recovery, unavailable API behavior and the complete physical audit within the original returned isolation deadline. Retain every rejected bounded sample and its original observations/error causes. Retry only a complete sample-bound admission/reason transition; other invariant, timeout and capture failures stay fatal. Qualification recovery reads and supported API/Mongo requests use the remaining budget. Backend admission/CAS, source authority and serving behavior are unchanged.
Validation:
f9d5b5b4.The initial private wrapper failed after the helper ran but before retaining its child exit. That attempt remains unaccepted; its evidence and both wrapper versions are preserved. Fresh uniquely named cases supplied the accepted results.
The real-server control uses a constructed empty-mutation prefix with retained source IDs. Historical cause, durability qualification, fresh full Linux 1..1480 worker replay and Wire/release acceptance remain separate under #191/#277.
Refs #341, #191, #277 and eosrio/hyperion-tools#24.