Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#1970 - New text entities in KET-format #2093

Open
wants to merge 111 commits into
base: master
Choose a base branch
from
Open

#1970 - New text entities in KET-format #2093

wants to merge 111 commits into from

Conversation

even1024
Copy link
Collaborator

@even1024 even1024 commented Jul 8, 2024 •
edited
Loading

Generic request

  • PR name follows the pattern #1234 – issue name
  • branch name does not contain '#'
  • base branch (master or release/xx) is correct
  • PR is linked with the issue
  • task status changed to "Code review"
  • code follows product standards
  • regression tests updated

even1024 and others added 30 commits May 26, 2024 14:17
@even1024 even1024 marked this pull request as ready for review March 17, 2025 09:18
@even1024 even1024 added this to the Indigo-1.31.0-rc.1 (Current) milestone Mar 18, 2025
@even1024 even1024 linked an issue Mar 18, 2025 that may be closed by this pull request
New text entities in KET-format #1970
Open
@even1024 even1024 removed this from the Indigo-1.31.0-rc.1 (Current) milestone Mar 18, 2025
AliaksandrDziarkach
AliaksandrDziarkach reviewed Mar 18, 2025
View reviewed changes
core/indigo-core/molecule/json_writer.h
@@ -172,6 +172,62 @@ namespace indigo
_writer.Flush();
}

void WritePoint(const Vec2f& point)
{
if (pretty_json)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe better use something like

            auto& writer = pretty_json ? _pretty_writer : _writer;
            writer.StartObject();
            .....

?

This was linked to issues Mar 20, 2025
System ignores carrige return in text blocks in loaded CDX #1679
Open
System shifts text label to the right #1683
Open
AlexanderSavelyev
AlexanderSavelyev requested changes Mar 21, 2025
View reviewed changes
Copy link
Collaborator

@AlexanderSavelyev AlexanderSavelyev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

issue with
api/tests/integration/tests/formats/ref/Amidation_Rxn1.b64cdx
api/tests/integration/tests/formats/ref/Amidation_Rxn2.b64cdx

image

api/tests/integration/tests/formats/ref/BuchwaldHartwig_Rxn1.b64cdx
image

AlexanderSavelyev
AlexanderSavelyev reviewed Mar 21, 2025
View reviewed changes
Copy link
Collaborator

@AlexanderSavelyev AlexanderSavelyev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

api/tests/integration/tests/formats/ref/Esterification_Rxn1.b64cdx as well

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexanderSavelyev AlexanderSavelyev AlexanderSavelyev requested changes

@AliaksandrDziarkach AliaksandrDziarkach AliaksandrDziarkach left review comments

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
Indigo
Status: In review
Milestone
No milestone
3 participants
@even1024 @AlexanderSavelyev @AliaksandrDziarkach