Feature/195 #205
Merged
Feature/195 #205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
April 25, 2017 15:43
Litanontaru
requested review from
Desperus,
YevIgn,
ex00,
tonycox and
MayerRoman
Desperus
reviewed
Apr 26, 2017
| @@ -36,7 +36,7 @@ | |||
| private volatile Producers producers; | |||
|
|
|||
| public ProducersManager(KafkaFactory kafkaFactory, KeyTransformer keyTransformer, ValueTransformer valueTransformer, | |||
| List<SubscriberConfig> configs, Serializer serializer) { | |||
| List<com.epam.lagerta.kafka.config.SubscriberConfig> configs, Serializer serializer) { | |||
There was a problem hiding this comment.
Why fully qualified name?
Desperus
reviewed
Apr 26, 2017
| @@ -41,7 +41,7 @@ | |||
| private final ValueTransformer valueTransformer; | |||
| private final Serializer serializer; | |||
|
|
|||
| public TransactionalKafkaProducerImpl(SubscriberConfig subscriberConfig, KafkaFactory kafkaFactory, | |||
| public TransactionalKafkaProducerImpl(com.epam.lagerta.kafka.config.SubscriberConfig subscriberConfig, KafkaFactory kafkaFactory, | |||
There was a problem hiding this comment.
Why fully qualified name?
Desperus
reviewed
Apr 26, 2017
| private final String gapTopic; | ||
| private final Properties producerConfig; | ||
|
|
||
| public SubscriberConfig(String subscriberId, boolean suspendAllowed, String inputTopic, String reconciliationTopic, String gapTopic, Properties producerConfig) { |
There was a problem hiding this comment.
Probably better to shift variable type to new line too
Desperus
reviewed
Apr 26, 2017
| <bean id="data-recovery-config" class="com.epam.lagerta.kafka.DataRecoveryConfig" | ||
| p:reconciliationTopic="reconciliation"/> | ||
| p:reconciliationTopic="recon" | ||
| p:gapTopic="reconciliation" |
There was a problem hiding this comment.
Maybe rename this topic in tests to not confuse with "recon" one?
Desperus
reviewed
Apr 26, 2017
| @@ -67,10 +67,10 @@ | |||
|
|
|||
| <bean id="reconciler" class="com.epam.lagerta.mocks.ProxyReconciler"> | |||
| <constructor-arg> | |||
| <!--todo--> | |||
YevIgn
reviewed
Apr 26, 2017
| @Override | ||
| @SuppressWarnings("unchecked") | ||
| public Future<RecordMetadata> commitTransaction(long transactionId) { | ||
| int partition = 0; |
There was a problem hiding this comment.
Why not make this a constant?
There was a problem hiding this comment.
It is not my code. It was moved from original class
There was a problem hiding this comment.
Can you add a todo here? So it will be then a part of a later ticket oriented on todo cleanup.
There was a problem hiding this comment.
added todo and #208
Desperus
reviewed
Apr 26, 2017
| consumer = kafkaFactory.consumer(dataRecoveryConfig.getConsumerConfig()); | ||
| private GapFixer() { | ||
| producer = kafkaFactory.producer(clusterConfig.getKafkaConfig().getProducerConfig()); | ||
| consumer = kafkaFactory.consumer(clusterConfig.getKafkaConfig().getConsumerConfig(GAP_FIX_ID + UUID.randomUUID())); |
There was a problem hiding this comment.
Do we need unique gap fix group id for each GapFixer?
tonycox
approved these changes
Apr 26, 2017
ex00
approved these changes
Apr 26, 2017
MayerRoman
approved these changes
Apr 26, 2017
YevIgn
approved these changes
Apr 26, 2017
Desperus
approved these changes
Apr 27, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixed #195