234 fixed problems for reinit lead state #235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ex00
requested review from
Desperus,
YevIgn,
Litanontaru,
tonycox and
MayerRoman
Desperus
reviewed
May 2, 2017
| .entrySet() | ||
| .stream() | ||
| .collect(Collectors.toMap(Map.Entry::getKey, v -> new OffsetAndMetadata(v.getValue().offset()))); | ||
| .entrySet(); |
There was a problem hiding this comment.
This can be done via pure streams. You sure this variant is more readable?
YevIgn
reviewed
May 2, 2017
| @@ -84,6 +83,8 @@ public CommittedTransactions loadCommitsAfter(long commitId) { | |||
| return committed; | |||
| }).join(); | |||
| return committed; | |||
| } catch (Exception e) { | |||
| throw new RuntimeException(e); | |||
| } finally { | |||
| consumerKeepers.forEach(ConsumerKeeper::close); | |||
There was a problem hiding this comment.
Closing ConsumerKeepers in the loop is not safe as if one of them throws the rest will not be closed properly. May be add a todo here?
There was a problem hiding this comment.
Or I suggest make ConcumerKeeper implement Autocloseable and then use
org.apache.ignite.internal.util.IgniteUtils#closeQuiet(java.lang.AutoCloseable)
in the same stream.
There was a problem hiding this comment.
It will swallow all exceptions in that case. We probably should log them at least.
There was a problem hiding this comment.
I added todo and created issue(#236) for fix it
MayerRoman
approved these changes
May 2, 2017
Desperus
approved these changes
May 2, 2017
YevIgn
approved these changes
May 2, 2017
tonycox
approved these changes
May 2, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #234