Add support to monitor CPU temperature#45
Closed
ffeldbauer wants to merge 3 commits intoepics-modules:masterfrom
Closed
Add support to monitor CPU temperature#45ffeldbauer wants to merge 3 commits intoepics-modules:masterfrom
ffeldbauer wants to merge 3 commits intoepics-modules:masterfrom
Conversation
Added support to monitor the CPU temperature on Linux. New function uses the LOAD_TYPE scan rate like all the other CPU related informations.
simon-ess
requested changes
Jan 12, 2023
Contributor
simon-ess
left a comment
simon-ess
left a comment
There was a problem hiding this comment.
A few other minor comments:
- I can't really test this locally myself as my local machine doesn't have that file. But the idea seems sensible, I suppose.
- Please update the
README_devIocStatsfile with your new entry
- Replaced blanks by tab for intendation in `devIocStats/devIocStatsAnalog.c` - Added the new entry in `README_devIocStats`
Contributor
|
LGTM, but note that there are now some conflicts with |
Author
|
Yes, I have noticed. Fixed with newest commit |
Contributor
|
I did add a CI pipeline to this, and it seems that your resolution to the issue has undone that. |
Author
|
Not sure, why the submodule was not merged correctly. Due to some new merge conflicts with the latest master, I created a new "fork". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Somehow I was missing the CPU temperature in this module, so I tried to add it at least for Linux.
I implemented the function like the CPU utilization and used the same scan rate (
LOAD_TYPE) for it