Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Sentry #961

Merged
merged 1 commit into from
Mar 11, 2025
Merged

Update Sentry #961

merged 1 commit into from
Mar 11, 2025

Conversation

nichtsam
Copy link
Contributor

Official Sentry SDK for React Router Framework is out.
https://www.npmjs.com/package/@sentry/react-router

Test Plan

Checklist

  • Tests updated
  • Docs updated

Screenshots

Copy link
Member

@kentcdodds kentcdodds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks a lot!

@kentcdodds kentcdodds merged commit b78978e into epicweb-dev:main Mar 11, 2025
5 checks passed
@zwhitchcox
Copy link
Contributor

Just a note that that project is in alpha status, and says it could have breaking changes. Does anyone know if these changes are likely to be significant enough to cause a significant rewrite? I'm guessing probably not or you wouldn't have merged

@nichtsam nichtsam deleted the pr/sentry-update branch March 25, 2025 14:13
@nichtsam
Copy link
Contributor Author

Just a note that that project is in alpha status, and says it could have breaking changes. Does anyone know if these changes are likely to be significant enough to cause a significant rewrite? I'm guessing probably not or you wouldn't have merged

The biggest rewrite was when we switched from Remix to the React Router framework due to the lack of an SDK at the time. Now that the React Router SDK is available, it closely resembles how the Remix SDK was used. Personally, I don’t expect another major rewrite, as most logic is encapsulated within the SDK, and other SDKs follow a similar pattern. I see the alpha status as a reminder to be cautious with updates and pay close attention to the details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants