Skip to content

feat: 3d-scene #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jan 16, 2024
Merged

feat: 3d-scene #7

merged 4 commits into from
Jan 16, 2024

Conversation

pussypistolss
Copy link
Contributor

@pussypistolss pussypistolss commented Jan 9, 2024 •
edited
Loading

image

@pussypistolss pussypistolss linked an issue Jan 9, 2024 that may be closed by this pull request
Hate #4
Open
TorinAsakura
TorinAsakura requested changes Jan 9, 2024
View reviewed changes
Copy link
Member

@TorinAsakura TorinAsakura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • имя папки в нижний регистр
  • когда объектных типов несколько - создавай для них папки, например albums/hate/zbrush; albums/hate/3dm; albums/hate/renders

TorinAsakura
TorinAsakura requested changes Jan 10, 2024
View reviewed changes
Copy link
Member

@TorinAsakura TorinAsakura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Hate всё также начинается с верхнего регистра (capitalize)
  • артефакты Юры нам не нужны, только если они не нужны тебе

TorinAsakura
TorinAsakura requested changes Jan 11, 2024
View reviewed changes
Copy link
Member

@TorinAsakura TorinAsakura left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • коммиты не подписаны
  • часть коммитов не по конвенции

@pussypistolss pussypistolss force-pushed the feat/3d-scene branch 3 times, most recently from 0167398 to 9f89630 Compare January 11, 2024 18:36
TorinAsakura
TorinAsakura requested changes Jan 11, 2024
View reviewed changes
Copy link
Member

@TorinAsakura TorinAsakura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • что такое main scene? и почему там используется пробел?
  • что такое buindings3d?
  • что такое references/surfaces?
    Если говорить вкратце - то я не понимаю, для чего нам нужны тут эти ассеты

TorinAsakura
TorinAsakura requested changes Jan 11, 2024
View reviewed changes
Copy link
Member

@TorinAsakura TorinAsakura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

зачем ты запаблила свой ключ в репозиторий? что ты делаешь?)

TorinAsakura
TorinAsakura requested changes Jan 11, 2024
View reviewed changes
Copy link
Member

@TorinAsakura TorinAsakura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

видимо необходимо разделить контекстную зону ответственности:

  • scene
  • -- scene/blender
  • character
  • -- character/zbrush

@TorinAsakura TorinAsakura merged commit 1734162 into master Jan 16, 2024
@TorinAsakura TorinAsakura deleted the feat/3d-scene branch January 16, 2024 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TorinAsakura TorinAsakura TorinAsakura approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Hate
2 participants
@pussypistolss @TorinAsakura