Skip to content

Commit

Permalink
fix: update ag-grid dependencies and refactor imports (#2491)
Browse files Browse the repository at this point in the history
  • Loading branch information
odinr authored Feb 26, 2025
1 parent 3bdfc81 commit a1c95c3
Show file tree
Hide file tree
Showing 5 changed files with 29 additions and 14 deletions.
6 changes: 6 additions & 0 deletions .changeset/hip-views-fry.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
---
'@equinor/fusion-react-ag-grid-person-cell': patch
'@equinor/fusion-react-components-stories': patch
---

fixed deps for ag-grid
6 changes: 4 additions & 2 deletions packages/ag-grid-person-cell/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -48,12 +48,14 @@
"styled-components": "^6.1.14"
},
"peerDependencies": {
"@equinor/fusion-framework-module-ag-grid": "^33.0.0",
"@equinor/eds-core-react": "^0.39.0",
"@equinor/eds-tokens": "^0.9.2"
"@equinor/eds-tokens": "^0.9.2",
"ag-grid-community": "33",
"react": "^17.0.0 || ^18.0.0"
},
"devDependencies": {
"@types/react": "^18.2.74",
"ag-grid-community": "33.1.1",
"react": "^18.2.0"
}
}
2 changes: 1 addition & 1 deletion packages/ag-grid-person-cell/src/agPersonCell.tsx
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { ColDef, ICellRendererParams } from '@equinor/fusion-framework-module-ag-grid/community';
import { type ColDef, type ICellRendererParams } from 'ag-grid-community';
import { PersonCellData, PersonCell, PersonItemSize } from '@equinor/fusion-react-person';
import { personTooltip } from './personTooltip';
import { personSortComparator } from './personSort';
Expand Down
20 changes: 16 additions & 4 deletions pnpm-lock.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Original file line number Diff line number Diff line change
Expand Up @@ -11,13 +11,7 @@ import { faker } from '@faker-js/faker';

// AgGrid
import { AgGridReact } from 'ag-grid-react';
import {
ClientSideRowModelModule,
ColDef,
ModuleRegistry,
themeAlpine,
TooltipModule,
} from '@equinor/fusion-framework-module-ag-grid/community';
import { type ColDef, ClientSideRowModelModule, ModuleRegistry, themeAlpine, TooltipModule } from 'ag-grid-community';

const meta: Meta<typeof PersonCell> = {
title: 'ag-grid/Person Cell',
Expand All @@ -44,6 +38,7 @@ const meta: Meta<typeof PersonCell> = {
},
};

// @AndrejNikolicEq - Theme is missing
ModuleRegistry.registerModules([ClientSideRowModelModule, TooltipModule]);

export default meta;
Expand Down

0 comments on commit a1c95c3

Please sign in to comment.