Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(typescript): updating typescript to 5. and support for node 20 #1393

Merged
merged 1 commit into from
Jan 19, 2024

Conversation

eikeland
Copy link
Contributor

@eikeland eikeland commented Jan 19, 2024

Component Development

  • Update to typescript 5.3.3
  • Support for node 20 sp we can use LTS version.
  • Fixes eslint warning for type imports

Type

  • Feature
  • Fix
  • Hotfix (should release ASAP)
  • Maintenance (deps only)

Reference to assignment

Description of assignment

Description of Proposed Changes

Checklist

Create User Story(DevOps) or Issue(Github)

  • Describe functional requirements
  • Design plan/suggestion (e.g. images, link to eds design or relevant figma links, mention of eds tokens to use)
  • Communication with UX (evaluate if needed)

Development

  • Describe the component
  • Code funtional requirements
  • Create stories
  • Create snapshots (evaluate if needed)
  • Remove unused imports and commented code
  • Lint code with EsLint (and follow best practises for code quality

Create Pull Request

  • Assign relevant reviewers in Github and Cromatic
  • Inform colleagues of pending reviews. We use Teams for this purpose, under fusion-frontend team please tag involved reviewers in the Code review channel

Review of Pull Request

  • Follow up on comments from code review and implement necessary changes (evaluate if needed)
  • Review approved in github (and chromatic)

Publish Code

  • Increment version number
  • Merge PR
  • Consider letting fusion developers know this this shiny new thing exists

Copy link

changeset-bot bot commented Jan 19, 2024

⚠️ No Changeset found

Latest commit: b452433

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@eikeland eikeland self-assigned this Jan 19, 2024
@eikeland eikeland added bug Something isn't working dependencies Pull requests that update a dependency file labels Jan 19, 2024
@eikeland eikeland marked this pull request as ready for review January 19, 2024 11:50
@eikeland eikeland changed the title chore(typescript): updatiing typescript to 5. and support for node 20 chore(typescript): updating typescript to 5. and support for node 20 Jan 19, 2024
@eikeland eikeland force-pushed the chore/dependency/typescript branch from e4a22e5 to b452433 Compare January 19, 2024 12:33
Copy link
Contributor

@asbjornhaland asbjornhaland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

PS I see that the setup-node action still uses node 18.

@eikeland
Copy link
Contributor Author

yes, but we only support using node 20 on local dev. we can update workflows later

@eikeland eikeland merged commit a02c069 into main Jan 19, 2024
6 checks passed
@eikeland eikeland deleted the chore/dependency/typescript branch January 19, 2024 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants