Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(storybook): story for PersonSelect selectedPerson attribute #1484

Merged
merged 4 commits into from
Feb 19, 2024

Conversation

eikeland
Copy link
Contributor

@eikeland eikeland commented Feb 15, 2024

Component Development

Ref AB#47637

Adds storybook entry for selectedPerson. Remove unused attributes from docs.

Type

  • Feature
  • Fix
  • Hotfix (should release ASAP)
  • Maintenance (deps only)

Reference to assignment

Description of assignment

Description of Proposed Changes

Checklist

Create User Story(DevOps) or Issue(Github)

  • Describe functional requirements
  • Design plan/suggestion (e.g. images, link to eds design or relevant figma links, mention of eds tokens to use)
  • Communication with UX (evaluate if needed)

Development

  • Describe the component
  • Code funtional requirements
  • Create stories
  • Create snapshots (evaluate if needed)
  • Remove unused imports and commented code
  • Lint code with EsLint (and follow best practises for code quality

Create Pull Request

  • Assign relevant reviewers in Github and Cromatic
  • Inform colleagues of pending reviews. We use Teams for this purpose, under fusion-frontend team please tag involved reviewers in the Code review channel

Review of Pull Request

  • Follow up on comments from code review and implement necessary changes (evaluate if needed)
  • Review approved in github (and chromatic)

Publish Code

  • Increment version number
  • Merge PR
  • Consider letting fusion developers know this this shiny new thing exists

Copy link

changeset-bot bot commented Feb 15, 2024

🦋 Changeset detected

Latest commit: 77d27cb

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@equinor/fusion-react-components-stories Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@eikeland eikeland self-assigned this Feb 15, 2024
@eikeland eikeland force-pushed the chore/person/select/selectedperson/docs branch from 16d1680 to 8f44760 Compare February 16, 2024 14:46
@eikeland eikeland force-pushed the chore/person/select/selectedperson/docs branch from 8f44760 to 0a7910e Compare February 16, 2024 14:47
@eikeland eikeland marked this pull request as ready for review February 16, 2024 14:55
@eikeland eikeland added the documentation Improvements or additions to documentation label Feb 16, 2024
@eikeland eikeland merged commit 3f20acf into main Feb 19, 2024
8 checks passed
@eikeland eikeland deleted the chore/person/select/selectedperson/docs branch February 19, 2024 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants