Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support for searching with azureId on selectedPerson property #1533

Merged
merged 2 commits into from
Feb 29, 2024

Conversation

eikeland
Copy link
Contributor

@eikeland eikeland commented Feb 29, 2024

Component Development

Updates fwc-person to add support for searching with azureId on selectedPerson property.

Reference: AB#49390

Type

  • Feature
  • Fix
  • Hotfix (should release ASAP)
  • Maintenance (deps only)

Reference to assignment

Description of assignment

Description of Proposed Changes

Checklist

Create User Story(DevOps) or Issue(Github)

  • Describe functional requirements
  • Design plan/suggestion (e.g. images, link to eds design or relevant figma links, mention of eds tokens to use)
  • Communication with UX (evaluate if needed)

Development

  • Describe the component
  • Code funtional requirements
  • Create stories
  • Create snapshots (evaluate if needed)
  • Remove unused imports and commented code
  • Lint code with EsLint (and follow best practises for code quality

Create Pull Request

  • Assign relevant reviewers in Github and Cromatic
  • Inform colleagues of pending reviews. We use Teams for this purpose, under fusion-frontend team please tag involved reviewers in the Code review channel

Review of Pull Request

  • Follow up on comments from code review and implement necessary changes (evaluate if needed)
  • Review approved in github (and chromatic)

Publish Code

  • Increment version number
  • Merge PR
  • Consider letting fusion developers know this this shiny new thing exists

@eikeland eikeland self-assigned this Feb 29, 2024
@eikeland eikeland added enhancement New feature or request prioritized ASAP dependencies Pull requests that update a dependency file labels Feb 29, 2024
@eikeland eikeland marked this pull request as ready for review February 29, 2024 10:00
Copy link

changeset-bot bot commented Feb 29, 2024

🦋 Changeset detected

Latest commit: 91a557e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@equinor/fusion-react-person Patch
@equinor/fusion-react-components-stories Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@eikeland eikeland merged commit 498d0a9 into main Feb 29, 2024
6 of 8 checks passed
@eikeland eikeland deleted the fix/person/select/deps/fwc branch February 29, 2024 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file enhancement New feature or request prioritized ASAP
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants