Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(side-sheet): add shouldAnimate as allowed attribute #2340

Merged
merged 1 commit into from
Dec 11, 2024

Conversation

asbjornhaland
Copy link
Contributor

@asbjornhaland asbjornhaland commented Dec 11, 2024

Ref equinor/fusion#464
Ref AB#58933

Component Development

Type

  • Feature
  • Fix
  • Hotfix (should release ASAP)
  • Maintenance (deps only)

Reference to assignment

Description of assignment

Description of Proposed Changes

Checklist

Create User Story(DevOps) or Issue(Github)

  • Describe functional requirements
  • Design plan/suggestion (e.g. images, link to eds design or relevant figma links, mention of eds tokens to use)
  • Communication with UX (evaluate if needed)

Development

  • Describe the component
  • Code funtional requirements
  • Create stories
  • Create snapshots (evaluate if needed)
  • Remove unused imports and commented code
  • Lint code with EsLint (and follow best practises for code quality

Create Pull Request

  • Assign relevant reviewers in Github and Cromatic
  • Inform colleagues of pending reviews. We use Teams for this purpose, under fusion-frontend team please tag involved reviewers in the Code review channel

Review of Pull Request

  • Follow up on comments from code review and implement necessary changes (evaluate if needed)
  • Review approved in github (and chromatic)

Publish Code

  • Increment version number
  • Merge PR
  • Consider letting fusion developers know this this shiny new thing exists

@asbjornhaland asbjornhaland requested a review from odinr December 11, 2024 13:58
@asbjornhaland asbjornhaland self-assigned this Dec 11, 2024
Copy link

changeset-bot bot commented Dec 11, 2024

🦋 Changeset detected

Latest commit: 5740e1b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@equinor/fusion-react-side-sheet Patch
@equinor/fusion-react-components-stories Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

odinr
odinr previously approved these changes Dec 11, 2024
@asbjornhaland asbjornhaland force-pushed the fix/side-sheet/allow-prop-should-animate branch from 193c7a4 to 5740e1b Compare December 11, 2024 14:00
@asbjornhaland asbjornhaland requested a review from odinr December 11, 2024 14:02
@odinr odinr merged commit f449132 into main Dec 11, 2024
6 of 8 checks passed
@odinr odinr deleted the fix/side-sheet/allow-prop-should-animate branch December 11, 2024 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants