Conversation
…preter into v6.0.0-getvar-fix
sethdusek
requested changes
Mar 12, 2025
| val c3 = stypeToElem(typeSubst.apply(tT)) | ||
| ctx.getVar(c2)(c3) | ||
| case SContextMethods.getVarFromInputMethod.name => | ||
| case SContextMethods.getVarFromInputMethod.name if VersionContext.current.isV6SoftForkActivated => |
Contributor
There was a problem hiding this comment.
Needs rebase to new versioning scheme?
sethdusek
approved these changes
Apr 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this PR, Context.getVar got removed, as having method with the same id but different behavior is not supported by clients < 6.0.
Another option was to introduce a new method with different id, but I guess new method Context.getVarFromInput() would be enough (in conjuction with selfIndex when read from self is required)