Skip to content

refactor: move logging config to CLI entrypoint and redact payloads (A5) #90

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ergut wants to merge 8 commits into
base: main
Choose a base branch
from
Open

refactor: move logging config to CLI entrypoint and redact payloads (A5) #90

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
99f1480
docs: add A5 logging refactor design spec
ergut Jul 19, 2026
bf83ca5
docs: add A5 logging refactor implementation plan
ergut Jul 19, 2026
5e1f1c3
feat: configure logging in CLI entrypoint, gated by LOGSEQ_LOG_LEVEL/…
ergut Jul 19, 2026
f929216
refactor: stop configuring root logger at server.py import time (A5)
ergut Jul 19, 2026
729b4ae
refactor: redact tool arguments/results from dispatch logging (A5)
ergut Jul 19, 2026
7e8d045
docs: document LOGSEQ_LOG_LEVEL/LOGSEQ_LOG_FILE and A5 logging changes
ergut Jul 19, 2026
8826104
fix: address final review — no property values in logs, cap MCP SDK l…
ergut Jul 19, 2026
b9e9f4b
chore: deterministic mcp-logger tests, document DEBUG-mode SDK cap
ergut Jul 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,13 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
(it always sets `verify_ssl` explicitly from the protocol), but external code
constructing the client directly against a self-signed HTTPS Logseq endpoint
must now pass `verify_ssl=False` explicitly (#89)
- **Potentially breaking:** logging is no longer configured at import time and
the server no longer writes `~/.cache/mcp-logseq/mcp_logseq.log` by default.
The CLI entrypoint now configures stderr logging at `INFO` (was `DEBUG`),
tunable via `LOGSEQ_LOG_LEVEL`; file logging is opt-in via `LOGSEQ_LOG_FILE`.
Tool arguments and results are redacted from logs — only tool names, argument
keys, and result sizes are recorded, so page/block content (including
ACL-gated pages) no longer lands in plaintext logs

### Internal

Expand Down
2 changes: 2 additions & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -207,6 +207,8 @@ If you hit the "already exists" error mid-ingest, use `get_page_content` to see
- **`LOGSEQ_API_URL`** (optional): Server URL (default: `http://localhost:12315`)
- **`LOGSEQ_API_CONNECT_TIMEOUT`** (optional): HTTP connect timeout in seconds (default: `3`)
- **`LOGSEQ_API_READ_TIMEOUT`** (optional): HTTP read timeout in seconds (default: `6`)
- **`LOGSEQ_LOG_LEVEL`** (optional): Log verbosity — `DEBUG`, `INFO`, `WARNING`, `ERROR`, or `CRITICAL` (default: `INFO`). Logs go to stderr. At `DEBUG`, the MCP SDK's own logger stays capped at `INFO` so full request payloads are not logged.
- **`LOGSEQ_LOG_FILE`** (optional): Path to a log file. When unset (the default), nothing is written to disk. Tool calls are logged with argument names and result sizes only, so page/block content does not appear in routine logs.
- **`LOGSEQ_DB_MODE`** (optional): Set to `true` to enable DB-mode property support. Only for Logseq DB-mode graphs (beta). Markdown/file-based graph users should leave this unset.
- **`LOGSEQ_EXCLUDE_TAGS`** (optional): Comma-separated tags — pages with these tags are hidden from all tools. See [Privacy & Access Control](#-privacy--access-control) below.
- **`LOGSEQ_INCLUDE_NAMESPACES`** (optional): Comma-separated namespace allow-list (e.g. `work,projects`). When set, **only** pages in these namespaces and their sub-pages are accessible — everything else, including top-level pages without a namespace, is hidden from listings/search and denied on direct access. See [Privacy & Access Control](#-privacy--access-control) below.
Expand Down
Loading