Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Corrected color inconsistencies #156

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

cyberlytics
Copy link

Changed color code of Bucket Sort, Radix Sort, and Counting Sort from green to yellow, to be in sync with the bigocheatsheet.com color code specs for O(n)

Changed color code of Bucket Sort, Radix Sort, and Counting Sort from green to yellow, to be in sync with the bigocheatsheet.com color code specs for O(n)
@cyberlytics
Copy link
Author

(Obviously this should also impact your beautiful poster variant.)

Without this correction you have a serious inconsistency with the (correct) yellow codings of Timsort, Bubble Sort, Insertion Sort and Cubesort in their Best Case scenario. They actualy perform better than Bucket Sort, Radix Sort, and Counting Sort but currently have the worse color.

I can understand that there was the intention to mark Bucket Sort, Radix Sort, and Counting Sort as the best algorithms?
But the current version is still colorwise broken, both the table and the poster.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants