[pull] main from hookdeck:main#160
Merged
Merged
Conversation
…977) * Redact eval artifact secrets and clarify quickstart polling snippets. Address Copilot review on #976: redact known secrets when writing transcripts and judge failures, and scan results/runs before CI upload. Co-Authored-By: Claude <noreply@anthropic.com> Co-authored-by: Cursor <cursoragent@cursor.com> * Add tests for eval artifact secret redaction. Cover pattern and literal env redaction, JSON artifact output, and wire npm run test:redact-secrets into npm run test. Co-Authored-By: Claude <noreply@anthropic.com> Co-authored-by: Cursor <cursoragent@cursor.com> * Extend eval artifact redaction to webhook URLs and CI env. Add EVAL_TEST_DESTINATION_URL and OUTPOST_TEST_WEBHOOK_URL to literal redaction; pass secrets into the CI redact step so re-scan can replace plain JSON echoes (Copilot review on #977). Co-Authored-By: Claude <noreply@anthropic.com> Co-authored-by: Cursor <cursoragent@cursor.com> * Fix eval artifact redaction corrupting JSON structure. Deep-walk artifact objects and redact string leaves before serialization so transcript.json stays parseable for heuristic scoring. Co-authored-by: Cursor <cursoragent@cursor.com> --------- Co-authored-by: Claude <noreply@anthropic.com> Co-authored-by: Cursor <cursoragent@cursor.com>
* Reconcile LLM judge overall pass with criteria array. Derive overall_transcript_pass from criteria when present so eval-ci does not fail when the model marks every criterion pass but overall false. Co-authored-by: Cursor <cursoragent@cursor.com> * Harden LLM judge boolean parsing per review feedback. Parse string "true"/"false" explicitly, apply the same to criteria pass fields, only log reconciliation when overall was explicitly set, and align test assertion messages with other eval unit tests. Co-authored-by: Cursor <cursoragent@cursor.com> --------- Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )