Stop circumventing the std definition of FromUtf8Error
#412
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarijnS95
force-pushed
the
give-users-FromUtf8Error
branch
from
b6a04c1 to
9d0369f
Compare
By already taking the `Vec<u8>` out of this error we leave users no choice to bubble up the error with typical `?` or `anyhow::Context::context()`, because `vec<u8>` does not implement `std::error::Error` (it's not an error after all). Instead of trying to outsmart the standard library and annoying the user, return the original `FromUtf8Error` *as it is*, leaving the caller to deal with it however they please (i.e. bubble it up, or call `into_bytes()` themselves if they wish to continue parsing it otherwise).
MarijnS95
force-pushed
the
give-users-FromUtf8Error
branch
from
9d0369f to
62d18df
Compare
Jasper-Bekkers
approved these changes
May 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By already taking the
Vec<u8>out of this error we leave users no choice to bubble up the error with typical?oranyhow::Context::context(), becausevec<u8>does not implementstd::error::Error(it's not an error after all).Instead of trying to outsmart the standard library and annoying the user, return the original
FromUtf8Erroras it is, leaving the caller to deal with it however they please (i.e. bubble it up, or callinto_bytes()themselves if they wish to continue parsing it otherwise).