Skip to content

Feat/sec 15 register jwt report #298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
larryjay007 wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Feat/sec 15 register jwt report #298

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ed8d326
docs: add SEC-23 security report - inconsistent token keys
larryjay007 Jun 29, 2026
b245daf
docs: add SEC-15 security report - register JWT without signature
larryjay007 Jun 30, 2026
a7356f7
docs: remove duplicate SEC-23 report
larryjay007 Jul 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions docs/security-reports/SEC-15-register-jwt-sin-firma.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
# SEC-15: /users/register emite JWT para dirección Stellar no verificada (bypass de firma)

## Resultado
El endpoint /users/register crea el usuario y devuelve un JWT válido sin requerir prueba de posesión de la llave privada (no challenge ni firma).

## Evidencia
- Archivo: apps/api/src/routes/users.ts:12-63
- Respuesta 201 con token JWT inmediato para cualquier stellar_address.
- No llama a auth challenge flow.

## Reproducible en testnet
Sí.

## Sugerencia de fix
Requerir challenge + firma antes de emitir JWT (unificar con /auth flow). O marcar como "unverified" hasta verificación.

## Estado
Reporte completado
Loading