ES2015: Modules: export
declarations (partial)
#80
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up to #79.
After reading the spec more and approaches such as Shift AST, I concluded we want to introduce
Module
as a top-level abstraction next toProgram
(and later replaceProgram
withScript
):— https://blog.shapesecurity.com/2015/01/06/a-technical-comparison-of-the-shift-and-spidermonkey-ast-formats/
This makes it less likely for invalid programs to inhabit the AST, e.g.
export
in aProgram
(later:Script
). I like their approach:I found out about Shift AST in connection with this project somewhere (can’t find the reference anymore). What’s the approach for the new AST? Would it make sense to follow Shift AST spec if possible? Might make for some nice potential interop and learning opportunities.
Update: Found the reference: #41 (comment)