Error when ignoreNonObjectArgs is unnecessary. #414
+52
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Agree on warning by default. Making this an error will cause a lot of unexpected problems for existing test suites. |
|
I will happily refactor this on top of #424 if that gets in. |
dmaclach
force-pushed
the
ignoring_verify
branch
from
296e5c3 to
458dabc
Compare
dmaclach
force-pushed
the
ignoring_verify
branch
from
458dabc to
95f6e97
Compare
dmaclach
force-pushed
the
ignoring_verify
branch
from
95f6e97 to
3da072d
Compare
dmaclach
force-pushed
the
ignoring_verify
branch
from
3da072d to
e7a8574
Compare
This encourages proper use of the APIS and keeps the testing code cleaner and easier to read.
dmaclach
force-pushed
the
ignoring_verify
branch
from
e7a8574 to
7fa24af
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This encourages proper use of the APIS and keeps the testing code cleaner and easier to
read.
I would like to probably actually implement this as a warning that could be turned into an error (see #413)