Skip to content

Conversation

@zzydxm
Copy link
Contributor

@zzydxm zzydxm commented Dec 1, 2025

Generalized data publishing logic of pg to a behavior module, so that it better supports version upgrade, and can be used for other data publishing scenarios.

I also changed the message sent between pg gen_servers to be a general update instead of tuples starts with join/leave. This makes it able to support more efficient APIs.

This replaces PR of #7609

I have a small change that makes pg:demonitor only return ok instead of ok | false, this is revertible but I believe no one is using the 'false' return

@github-actions
Copy link
Contributor

github-actions bot commented Dec 1, 2025

CT Test Results

No tests were run for this PR. This is either because the build failed, or the PR is based on a branch without GH actions tests configured.

Results for commit af93a98

To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass.

See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally.

Artifacts

// Erlang/OTP Github Action Bot

@max-au
Copy link
Contributor

max-au commented Dec 1, 2025

Tastes like gen_pubsub to me!
Now, while I like the general idea, when I thought of it, I'd expect it to be significantly more generic. To a degree of having local process registry - therefore not calling net_kernel:monitor_nodes at all. This is fairly common request to have "pg but local to a specific node".

@zzydxm
Copy link
Contributor Author

zzydxm commented Dec 1, 2025

Now, while I like the general idea, when I thought of it, I'd expect it to be significantly more generic. To a degree of having local process registry - therefore not calling net_kernel:monitor_nodes at all. This is fairly common request to have "pg but local to a specific node".

Oh do you mean start the gen_server without allowing it to have any cross-node communication? I can think how to add this functionality

@IngelaAndin IngelaAndin added the team:VM Assigned to OTP team VM label Dec 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

team:VM Assigned to OTP team VM

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants