-
Notifications
You must be signed in to change notification settings - Fork 3k
system: Add Secure Coding Guidelines #10431
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
system: Add Secure Coding Guidelines #10431
Conversation
bjorng
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent language and sound advice. My only comments are nitpicks.
dea105b to
f0819a9
Compare
55995be to
b3c028e
Compare
| occur once the numbers reach several megabits in size, and will in any event | ||
| throw an exception instead of wrapping around or otherwise behaving in an | ||
| unsafe manner ([`CWE-190`]). | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we add some kind of disclaimer that the statements about memory safety, leaks, and so forth assumes that the VM implementation is correct.
And if so add that it is very unlikely that there exists an undiscovered bug that can be exploited for things like remote code execution since most parts of the VM is exercised thoroughly by all code that is run during normal operation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, I don't think that's necessary. Other languages (e.g. Rust) make strong claims about how safe they are without disclaiming that a compiler or runtime bug of theirs ruins everything, and I don't want a less technical decision-maker to get the impression that we're less safe than those languages just because we're more honest.
Co-authored-by: "Rickard Green <[email protected]>"
b3c028e to
cf6a601
Compare
Our benefactors want a secure coding standard/guideline for Erlang, and in contrast to EEF's Secure Coding Recommendations they want it to be more along the lines of the SEI CERT Coding Standards. We need to have numbered and concrete rules, mappings to CWEs and OWASP risks and back, and must address the top
NCWEs and OWASP risks.This is an early draft to get a discussion started on how it should look, which recommendations/rules should be included, and so on. It is quite incomplete at the moment, and any and all feedback is most welcome.