Open
Conversation
Contributor
CT Test Results 1 files 11 suites 3m 10s ⏱️ Results for commit 9daca6b. ♻️ This comment has been updated with latest results. To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass. See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally. Artifacts
// Erlang/OTP Github Action Bot |
bjorng
requested changes
Mar 17, 2026
Contributor
bjorng
left a comment
bjorng
left a comment
There was a problem hiding this comment.
Looks good to me except for one thing.
| @@ -36,7 +36,7 @@ distributed in the sense that they, for example, use services on other nodes. | |||
|
|
|||
| Since a distributed application can move between nodes, some addressing | |||
| mechanism is required to ensure that it can be addressed by other applications, | |||
| regardless on which node it currently executes. This issue is not addressed | |||
| regardless of which node it currently executes. This issue is not addressed | |||
Contributor
There was a problem hiding this comment.
Suggested change
| regardless of which node it currently executes. This issue is not addressed | |
| regardless of which node it currently executes on. This issue is not addressed |
Co-authored-by: Maria Scott <maria-12648430@hnc-agency.org>
juhlig
force-pushed
the
fix_design_principles_typos
branch
from
5a2f219 to
9daca6b
Compare
bjorng
approved these changes
Mar 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.