Skip to content

Rewrite the last legacy catch in inet_db #10864

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
RaimoNiskanen wants to merge 1 commit into
base: master
Choose a base branch
from
+5 −8
Draft

Rewrite the last legacy catch in inet_db #10864

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 5 additions & 8 deletions lib/kernel/src/inet_db.erl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,6 @@
-module(inet_db).
-moduledoc false.

-compile(nowarn_deprecated_catch).

%% Store info about ip addresses, names, aliases host files resolver
%% options.
%% Also miscellaneous "stuff" related to sockets.
Expand Down Expand Up @@ -285,13 +283,12 @@ add_rc(File) ->
Error -> Error
end.

%% Add an inetrc binary term must be a rc list
%% Add an inetrc binary term that must be an rc list
add_rc_bin(Bin) ->
case catch binary_to_term(Bin) of
List when is_list(List) ->
add_rc_list(List);
_ ->
{error, badarg}
try binary_to_term(Bin) of
List when is_list(List) -> add_rc_list(List);
_ -> {error, badarg}
catch error : _ -> {error, badarg}
end.

add_rc_list(List) -> call({add_rc_list, List}).
Expand Down
Loading