extended_bin: Avoid using logger #945
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Log the root directory path only once during startup.
weiss
force-pushed
the
fix/avoid-logger
branch
from
bd34f5d to
3436081
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The user running the release may not have the privileges required to using
logger(1). In that case,logger(1)returns non-zero, so the extended start script would fail (due toset -e).Modern systems (e.g., systemd-based or container solutions) typically expect services to write log messages to the standard output, and the extended start script does this in other places already. Therefore, just don't bother with
logger(1)anymore.