[AIRE] fix(ci): resolve 2 bug(s) from PR #3 (run 30319113804) - #1
Open
svc-bcs-agent wants to merge 1 commit into
Open
[AIRE] fix(ci): resolve 2 bug(s) from PR #3 (run 30319113804)#1svc-bcs-agent wants to merge 1 commit into
svc-bcs-agent wants to merge 1 commit into
Conversation
… (run 30319113804) - Add a .pylintrc file compatible with pylint >= 3.0 (tested with pylint 4.x) to the repo root so the Blossom-CI shared-library Jenkinsfile uses it instead of its bundled copy which contains deprecated options removed in pylint 3+ (optimize-ast, files-output, no-space-check, etc.), causing E0015 (unrecognized-option) errors. - Use 'builtins.Exception' for overgeneral-exceptions (pylint 4.x requirement). - NOTE: The Jenkins shared library Jenkinsfile also hardcodes 'nvidia_tao_core' as the pylint target module, but this repo's package is 'nvidia_tao_daft'. That issue requires a fix in the Jenkins shared library (see linked issue). Signed-off-by: svc-bcs-agent <svc-bcs-agent@nvidia.com>
Author
|
/build |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds a pylint 4.x-compatible
.pylintrcfile to the tao-daft repo root, fixing part of the CI pipeline failure in run 30319113804 for PR NVIDIA-TAO#3.What changed
.pylintrc— A modern pylint configuration file compatible with pylint >= 3.0 (tested with 4.x). The Blossom-CI Jenkins shared library checks for a local.pylintrcbefore falling back to its bundled copy; the bundled copy contains deprecated options (optimize-ast,files-output,no-space-check, etc.) removed in pylint 3+, which causeE0015(unrecognized-option)errors. This repo-level file takes precedence and eliminates those errors.Bug groups addressed
pylintrc-deprecated-options.pylintrcto prevent E0015 errors from outdated bundled configwrong-pylint-module-namenvidia_tao_coreas pylint target; actual module isnvidia_tao_daft— requires external fixKnown issues without a fix (issue_only)
Bug Group g2 — Wrong pylint module target: The Jenkins CI pipeline uses
oss-pipelines/tao-core/Jenkinsfile.developfrom the shared library, which hardcodesnvidia_tao_coreas the pylint target module. Since tao-daft's package isnvidia_tao_daft, pylint fails withF0001(fatal): No module named nvidia_tao_core. This cannot be fixed from the tao-daft repo — it requires updating the Jenkins shared library or the Jenkins job configuration. See the linked issue for details and suggested remediation.Root cause
The
static_testsstage of the Jenkins pipeline fails because:.pylintrcissue (fixed here): No.pylintrcin repo → shared library injects outdated copy → pylint 4.x rejects deprecated options withE0015.pylint --rcfile .pylintrc nvidia_tao_corebut the module isnvidia_tao_daft.Testing
.pylintrcvalidated withconfigparser(all sections parse correctly)Fixes NVIDIA-TAO#58
Signed-off-by: svc-bcs-agent svc-bcs-agent@nvidia.com