Make runtype switch from "normal" to "async" a sticky setting

[spankywetfish]

In general use with multiple hosts it is (IMHO) more practical to have the jobs run asynchronously so that there is no need to wait for completion before performing the next task.

The changes made to RunType.js reflect that priority and default the job input to "async".
I've been running with this configuration for approximately 18 months with no known issues.

N.B.
Apologies if this is not the correct format for a pull request, it's a first for me.

[Erwin added:]
better solution is to remember the choice so that both styles are equally supported, see below for discussion.

[erwindon]

@spankywetfish
Technically, the PR is fine.
But I cannot change the default behavior of a feature, unless it is an improvement for everyone.
I cannot accept this as is.
But all is not lost...
There are alternatives that should work for all:

1. make the initial value based on a variable in the /etc/salt/master file
   rather technical and it would apply to all users
2. make the initial value based on a variable in some *.txt file
   rather technical and it would apply to all users
3. use 2 "Run command" buttons, one "Run command normal" and also "Run command async"
   no configuration, is per-use, but complicates GUI and conflicts with possible extensions in the future (e.g. batched runs).
4. make the initial value based on a plain local-storage-item, set according to the latest use
   no configuration, is per-user/per-browser, still looks simple, must make the default more visible to prevent confusion. risk on information leak through use of storage-items is negligible.

how about number 4?

don't worry on who should build it. I can do that.

[erwindon]

Additionally, I've created an implementation of proposal 4. See branch runtype4.

[spankywetfish]

It looks like we've both been doing the same thing slightly different ways, I've also updated Api,js so that the runtype is persistent across sessions. I'd hazzard that as I consider myself in no way a programmer, yours implementation is more elegant.

[erwindon]

I've hidden my branch runtype4.
we're nearly there, please look at the comments with the js code...

[erwindon]

when a page-refresh is done, all GUI values are unavoidably lost.
this function would then reset the value to "normal" and also save it.

• saving the value should only be done in function _updateRunTypeText, as that is the callback function from the dropdownlist.
• instead of runType = "normal", the saved value should be retrieved: runType = Utils.getStorageItem("local", "runtype", "normal"); (which itself will have a default of 'normal')

[spankywetfish]

Moved to _updateRunTypeText, and suggested modification for retrieval applied, all tested and linted.

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information

[erwindon]

for a next time...
please use a dedicated branch, which you can re-base until it is merged.
I rolled-back this merge and made it a regular commit.

[erwindon]

thanks for the addition!