Skip to content

Conversation

@Kroffie
Copy link

@Kroffie Kroffie commented Nov 24, 2025

Fix old nodesource.com repo to new

Fix old nodesource.com repo to new
@Kroffie Kroffie requested a review from a team as a code owner November 24, 2025 22:03
@Kroffie
Copy link
Author

Kroffie commented Nov 24, 2025

This should fix the build failing (: @ThijsEgberts

@ThijsEgberts ThijsEgberts added the dependencies Pull requests that update a dependency file label Nov 29, 2025
Copy link
Member

@marijnvanderhorst marijnvanderhorst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please note that the https://deb.nodesource.com/node_18.x URL pointed (and still seems to point) to a debian package repository, whereas the proposed https://deb.nodesource.com/setup_18.x URL seems to point to a bash script instead.

Looking at the bash script, it seems to take care of configuring the DEB package repository, so the manual repo configuration here should be replaced by executing the script instead, I'd think.

The Debian 12 distro comes with Node.js v18 included in the default package repository I believe. Hence, alternatively, we could update the docker base image to php:8.2-fpm-bookworm and install nodejs from the default debian repository (instead of the nodesource.com repository).

https://packages.debian.org/bookworm/nodejs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants