Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Django 4 Support, drop python 3.6-3.7 support #57

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

stefanwitchell1990
Copy link

@stefanwitchell1990 stefanwitchell1990 commented Sep 29, 2022

Description

Added Django 4.

Removed Python 3.6 - 3.7 support as Django 4 requires minimum 3.8

I noticed that when upgrading my project to Django 4, I was getting an error on;

cannot import name 'ugettext_lazy' from 'django.utils.translation'

However looks like it was fixed on -> https://github.com/escaped/django-inline-actions/pull/43/files but not released.

Please include a summary of the proposed changes.

Removal off Python 3.6-3.7
Added Django 4

Fixes #(issue)

Tests are passing as the initial issue was fixed in -> https://github.com/escaped/django-inline-actions/pull/43/files

Checklist

  • Tests covering the new functionality have been added
  • Code builds clean without any errors or warnings
  • Documentation has been updated
  • Changes have been added to the CHANGELOG.md
  • You added yourself to the CONTRIBUTORS.md

@stefanwitchell1990 stefanwitchell1990 changed the title remove support for python 3.6, 3.7 as Django 4 requires min 3.8 Django 4 Support, drop python 3.6-3.7 support Sep 29, 2022
@oriolclosa
Copy link

Any updates here?

@mschiegg
Copy link

@ashishnitinpatil
Copy link
Contributor

fixes #51

@tony
Copy link
Contributor

tony commented Jul 20, 2023

@escaped Thank you for the package! Any possibility you could take a look?

Copy link

@pmourelle pmourelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, pretty straightforward and awesome. Am I missing something?

@ShabaniAmir
Copy link

I installed the package from pip but it still has the error with 'ugettext'.

@shayneoneill
Copy link

@ShabaniAmir thats cos this fix aint merged. Looks like this package has been abandoned sadly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants