Skip to content

Fix registry publish button layout / 修复技能市场发布按钮布局#6630

Merged
SivanCola merged 1 commit into
esengine:main-v2from
SivanCola:fix/registry-publish-button-layout
Jul 18, 2026
Merged

Fix registry publish button layout / 修复技能市场发布按钮布局#6630
SivanCola merged 1 commit into
esengine:main-v2from
SivanCola:fix/registry-publish-button-layout

Conversation

@SivanCola

Copy link
Copy Markdown
Collaborator

Summary

  • isolate the registry toolbar's publish CTA from the publish panel layout class
  • add a source contract test that prevents the CTA and panel from sharing the layout class again

Root cause

The publish CTA reused the existing reg-publish class when it moved into the registry toolbar. The page-level .reg-publish section rule then overrode the shared button padding, rendering the CTA as a narrow vertical pill.

User impact

The publish CTA now renders as a normal horizontal button while the hidden publish panel keeps its existing section spacing and behavior.

Verification

  • npm test in site/: 21 passed
  • npm run build in site/: passed
  • git diff --check: passed
  • in-app browser: CTA renders at 82 × 45 px with 12 px 26 px padding

Compatibility and cache impact

  • no persisted data, API, or Wails contract changes
  • no provider-visible prompt, tool schema, request serialization, or cache behavior changes

Problem:
The registry publish CTA rendered as a narrow vertical pill instead of a normal horizontal button.

Root cause:
The CTA reused the publish panel's reg-publish class and inherited the panel's asymmetric section padding.

Fix:
Give the toolbar CTA a dedicated class and add a source contract test that keeps the CTA and panel layout classes separate.

Verification:
- npm test (site): 21 passed
- npm run build (site): passed
- In-app browser: CTA renders at 82 x 45 px with 12 px 26 px padding
@github-actions github-actions Bot added the v2 Go rewrite (1.x) — main-v2 branch, active development label Jul 18, 2026
@SivanCola
SivanCola marked this pull request as ready for review July 18, 2026 02:47
@SivanCola
SivanCola requested a review from esengine as a code owner July 18, 2026 02:47
@SivanCola
SivanCola enabled auto-merge (squash) July 18, 2026 02:47
@SivanCola
SivanCola merged commit 840cb6c into esengine:main-v2 Jul 18, 2026
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

v2 Go rewrite (1.x) — main-v2 branch, active development

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant