Skip to content

Credit CLI clipboard co-contributor / 致谢 CLI 剪贴板共同贡献者#6664

Merged
SivanCola merged 1 commit into
esengine:main-v2from
SivanCola:docs/credit-cli-clipboard-contributor
Jul 19, 2026
Merged

Credit CLI clipboard co-contributor / 致谢 CLI 剪贴板共同贡献者#6664
SivanCola merged 1 commit into
esengine:main-v2from
SivanCola:docs/credit-cli-clipboard-contributor

Conversation

@SivanCola

Copy link
Copy Markdown
Collaborator

Summary

Attribution

#6560 identified that OSC 52-only transcript copy did not reach the native pasteboard in terminals such as macOS Terminal, VS Code, and Cursor, and proposed writing through the operating-system clipboard path. #6632 subsequently landed the hardened integration with verified native writes, SSH isolation, and OSC 52 fallback. This PR permanently records that shared contribution.

Verification

  • git diff --check
  • ./scripts/check-cache-impact.sh
  • The underlying clipboard behavior was revalidated on current main-v2 with the focused CLI tests, the full internal/cli suite, race coverage, a real Cursor integrated-terminal pasteboard round trip, and deterministic local/SSH routing checks.

Compatibility

Documentation and attribution only. No runtime behavior, persisted data, API contract, or dependencies change.

Cache impact

Cache-impact: none — documentation and contributor metadata only.
Cache-guard: ./scripts/check-cache-impact.sh reports no cache-sensitive prompt or tool files changed.
System-prompt-review: N/A

Refs #6603, #6560, #6632.

Problem:
- The contributor behind esengine#6560 helped identify and solve the CLI clipboard compatibility gap, but the integrated esengine#6632 commit did not record that co-contribution.

Root cause:
- The final implementation was merged independently without a contributor trailer or a permanent acknowledgment next to the shipped fix.

Fix:
- Credit Andrei Kiparuk in the changelog and bilingual README acknowledgments.
- Add a public Co-authored-by trailer so GitHub records the contribution after merge.

Verification:
- git diff --check
- ./scripts/check-cache-impact.sh

Co-authored-by: Andrei Kiparuk <88461327+andrei-kiparuk@users.noreply.github.com>
@SivanCola
SivanCola requested a review from esengine as a code owner July 19, 2026 03:41
@github-actions github-actions Bot added the v2 Go rewrite (1.x) — main-v2 branch, active development label Jul 19, 2026
@SivanCola
SivanCola merged commit d0296b1 into esengine:main-v2 Jul 19, 2026
17 checks passed
SivanCola added a commit that referenced this pull request Jul 19, 2026
Context:
- PR #6664 recorded the #6560 author as a repository co-author and also added permanent attribution text to the changelog and bilingual READMEs.

Change:
- Restore CHANGELOG.md, README.md, and README.zh-CN.md to their exact pre-#6664 content.
- Keep the merged #6664 commit and its Co-authored-by attribution in Git history.

Verification:
- git diff --check
- Tree comparison against the first parent of #6664
- ./scripts/check-cache-impact.sh
SivanCola added a commit that referenced this pull request Jul 19, 2026
…docs

Revert #6664 documentation credit / 撤回 #6664 文档致谢
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

v2 Go rewrite (1.x) — main-v2 branch, active development

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant