Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: new rule prefer-catch #525

Merged
merged 3 commits into from
Oct 26, 2024
Merged

Conversation

brettz9
Copy link
Member

@brettz9 brettz9 commented Aug 1, 2024

What is the purpose of this pull request?

  • New rule

What changes did you make? (Give an overview)

Adds new rule prefer-catch to prefer catch over then(a, b) or then(null, b).

Closes #217.

Copy link

codecov bot commented Aug 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (bbcfcbf) to head (0b43d92).
Report is 67 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##              main      #525    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files           25        29     +4     
  Lines          649       774   +125     
  Branches       250       291    +41     
==========================================
+ Hits           649       774   +125     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

rules/lib/parentheses.js Show resolved Hide resolved
rules/prefer-catch.js Outdated Show resolved Hide resolved
@brettz9 brettz9 requested a review from a team October 16, 2024 22:27
Copy link
Member

@ota-meshi ota-meshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@brettz9 brettz9 merged commit 05c8a93 into eslint-community:main Oct 26, 2024
11 checks passed
@brettz9 brettz9 deleted the prefer-catch branch October 26, 2024 03:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prefer calling then and catch separately to combining them into a single then
3 participants