chore: standardize npm script names #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
package.json
Outdated
Comment on lines
16
to
20
| "release:generate:latest": "eslint-generate-release", | ||
| "release:generate:alpha": "eslint-generate-prerelease alpha", | ||
| "release:generate:beta": "eslint-generate-prerelease beta", | ||
| "release:generate:rc": "eslint-generate-prerelease rc", | ||
| "release:publish": "eslint-publish-release", |
There was a problem hiding this comment.
These commands don't seem to work, for example:
> [email protected] release:generate:latest
> eslint-generate-release
'eslint-generate-release' is not recognized as an internal or external command,
operable program or batch file.
I did npm install but that doesn't seem to handle bin from the package itself.
There was a problem hiding this comment.
Yeah, we have to run the local file because we are releasing the tool in question. :)
There was a problem hiding this comment.
I did npm install but that doesn't seem to handle bin from the package itself.
I think you will need to run the npm link command as well. But I'll revert it to the old behavior.
Updated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
What is the purpose of this pull request?
Refers eslint/eslint#14827
What changes did you make? (Give an overview)
This updates the names of the scripts in package.json to be consistent with the new standard.
Is there anything you'd like reviewers to focus on?
We may need to update the
releaserelated scripts on Jenkins before merging this PR.