feat!: Resolve references to global var/function, add addGlobals()
#682
+477
−55
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdjermanovic
changed the title
var and function references on global scopevar/function, add addGlobals()
1 task
mdjermanovic
force-pushed
the
issue665
branch
from
6353dc4 to
e08692c
Compare
Member
Author
|
This is ready for review. Related PR in eslint/eslint is eslint/eslint#20132. |
fasttime
approved these changes
Oct 2, 2025
Member
fasttime
left a comment
fasttime
left a comment
There was a problem hiding this comment.
LGTM, thanks! Waiting for a second review.
github-project-automation
bot
moved this from Second Review Needed
to Complete
in Triage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
What is the purpose of this pull request?
Updates
eslint-scopeto resolve references to globally declaredvarandfunctionvariables, and adds a method to create predefined global variables.What changes did you make? (Give an overview)
varandfunctionvariables.ScopeManager#addGlobals()method that allows adding predefined globals.Related Issues
Fixes #665
Is there anything you'd like reviewers to focus on?
It would probably be more elegant to pass a list of predefined globals in advance, as an option to
analyze. But that doesn't fit the use of eslint-scope and other scope managers in ESLint, where the scope is analyzed in the parse step, whereas globals are added inSourceCode#finalize().